Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #272]Fix NamedThreadFactory attribute typo #273

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[ISSUE #272]Fix NamedThreadFactory attribute typo #273

merged 1 commit into from
Feb 22, 2023

Conversation

mxsm
Copy link
Contributor

@mxsm mxsm commented Feb 4, 2023

close #272

tsunghanjacktsai
tsunghanjacktsai requested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI first. Thx.

@mxsm
Copy link
Contributor Author

mxsm commented Feb 21, 2023

@tsunghanjacktsai Done PTAL~ thanks

TheR1sing3un
TheR1sing3un approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin merged commit b227855 into openmessaging:master Feb 22, 2023
@mxsm mxsm deleted the dledger-272 branch February 22, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheR1sing3un TheR1sing3un TheR1sing3un approved these changes

@tsunghanjacktsai tsunghanjacktsai Awaiting requested review from tsunghanjacktsai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix NamedThreadFactory attribute typo
4 participants
@mxsm @tsunghanjacktsai @TheR1sing3un @RongtongJin